Skip to content

Fix invalid display of enum sub-fields docs #44192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2017
Merged

Fix invalid display of enum sub-fields docs #44192

merged 1 commit into from
Sep 1, 2017

Conversation

GuillaumeGomez
Copy link
Member

Before:

screen shot 2017-08-30 at 23 17 00

After:

screen shot 2017-08-30 at 23 16 48

cc @nox @rust-lang/docs

@rust-highfive
Copy link
Contributor

Some changes occurred in HTML/CSS.

cc @GuillaumeGomez

@rust-highfive
Copy link
Contributor

r? @QuietMisdreavus

(rust_highfive has picked a reviewer for you, use r? to override)

@QuietMisdreavus
Copy link
Contributor

What version of rustdoc was used to render that "before" example? It looks like it doesn't include #43862.

That said, this does include more changes than that. I like the new styling, so i'm inclined to add this anyway.

@GuillaumeGomez
Copy link
Member Author

No idea. It's an old one which didn't have a JS fix. However, the style was still broken so this PR fixes it.

@nox
Copy link
Contributor

nox commented Aug 31, 2017

Initial screenshot is with Servo's nightly Rust, which is 13d94d5.

@nox
Copy link
Contributor

nox commented Aug 31, 2017

So I guess servo/servo#18325 should fix our issue, given that does a rustup.

@QuietMisdreavus
Copy link
Contributor

It fixes the issue, yeah, but this CSS change still adds some much-needed padding to the toggle labels. With just that JS change, there's no space between the [-] and the label itself. Like i said, i'm willing to land this anyway; i just wanted to note that "the label is under the button" was fixed by another change.

For example, here's std::heap::AllocErr in today's nightly docs:

image

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 31, 2017

📌 Commit bde0071 has been approved by QuietMisdreavus

@aidanhs aidanhs added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 31, 2017
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 31, 2017
@GuillaumeGomez
Rollup merge of rust-lang#44192 - GuillaumeGomez:sub-fields-style, r=…
12809b0 
…QuietMisdreavus

Fix invalid display of enum sub-fields docs

Before:

<img width="1440" alt="screen shot 2017-08-30 at 23 17 00" src="https://user-images.githubusercontent.com/3050060/29895433-61f2bf8c-8dd9-11e7-83e8-cf1dca878100.png">

After:

<img width="1440" alt="screen shot 2017-08-30 at 23 16 48" src="https://user-images.githubusercontent.com/3050060/29895441-66dea042-8dd9-11e7-9576-11b0c770c70b.png">

cc @nox @rust-lang/docs
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 31, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 1, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#44192 - GuillaumeGomez:sub-fields-style, r=…
fd5a945 
…QuietMisdreavus

Fix invalid display of enum sub-fields docs

Before:

<img width="1440" alt="screen shot 2017-08-30 at 23 17 00" src="https://user-images.githubusercontent.com/3050060/29895433-61f2bf8c-8dd9-11e7-83e8-cf1dca878100.png">

After:

<img width="1440" alt="screen shot 2017-08-30 at 23 16 48" src="https://user-images.githubusercontent.com/3050060/29895441-66dea042-8dd9-11e7-9576-11b0c770c70b.png">

cc @nox @rust-lang/docs
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 1, 2017
Merged
bors added a commit that referenced this pull request Sep 1, 2017
@bors
Auto merge of #44233 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
45d31e7 
Rollup of 10 pull requests

- Successful merges: #44192, #44199, #44202, #44203, #44205, #44207, #44209, #44223, #44230, #44231
- Failed merges:
@bors bors merged commit bde0071 into rust-lang:master Sep 1, 2017
@GuillaumeGomez GuillaumeGomez deleted the sub-fields-style branch September 1, 2017 19:43
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 2, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 2, 2022
@matthiaskrgr
Rollup merge of rust-lang#101323 - GuillaumeGomez:remove-unused-css, …
e77b8ce 
…r=notriddle

Remove unused .toggle-label CSS rule

It was added in rust-lang#44192 but since we moved to `<details>`, we don't use this rule any more.

r? `@notriddle`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @rust-highfive @QuietMisdreavus @nox @bors @aidanhs